[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 3/9] Convert yajl check to use LIBVIRT_CHECK_LIB_ALT



On 01/10/2013 01:18 PM, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange" <berrange redhat com>
> 
> Signed-off-by: Daniel P. Berrange <berrange redhat com>
> ---
>  configure.ac    | 87 ++-------------------------------------------------------
>  m4/virt-yajl.m4 | 34 ++++++++++++++++++++++
>  2 files changed, 37 insertions(+), 84 deletions(-)
>  create mode 100644 m4/virt-yajl.m4

ACK once you fix the following problems:

> +++ b/m4/virt-yajl.m4
> @@ -0,0 +1,34 @@
> +dnl The libyajl.so library

Missing a Copyright notice.

> +
> +AC_DEFUN([LIBVIRT_CHECK_YAJL],[
> +  dnl YAJL JSON library http://lloyd.github.com/yajl/
> +  if test "$with_qemu:$with_yajl" = yes:check; then
> +    dnl Some versions of qemu require the use of yajl; try to detect them
> +    dnl here, although we do not require qemu to exist in order to compile.
> +    dnl This check mirrors src/qemu/qemu_capabilities.c

Now that you have moved the comment, you need to update
src/qemu/qemu_capabilities.c to point to virt-yajl.m4 instead of
configure.ac as the other end of the linked check.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]