[libvirt] [PATCH 3/9] Convert yajl check to use LIBVIRT_CHECK_LIB_ALT
Eric Blake
eblake at redhat.com
Thu Jan 10 23:16:34 UTC 2013
On 01/10/2013 01:18 PM, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange" <berrange at redhat.com>
>
> Signed-off-by: Daniel P. Berrange <berrange at redhat.com>
> ---
> configure.ac | 87 ++-------------------------------------------------------
> m4/virt-yajl.m4 | 34 ++++++++++++++++++++++
> 2 files changed, 37 insertions(+), 84 deletions(-)
> create mode 100644 m4/virt-yajl.m4
ACK once you fix the following problems:
> +++ b/m4/virt-yajl.m4
> @@ -0,0 +1,34 @@
> +dnl The libyajl.so library
Missing a Copyright notice.
> +
> +AC_DEFUN([LIBVIRT_CHECK_YAJL],[
> + dnl YAJL JSON library http://lloyd.github.com/yajl/
> + if test "$with_qemu:$with_yajl" = yes:check; then
> + dnl Some versions of qemu require the use of yajl; try to detect them
> + dnl here, although we do not require qemu to exist in order to compile.
> + dnl This check mirrors src/qemu/qemu_capabilities.c
Now that you have moved the comment, you need to update
src/qemu/qemu_capabilities.c to point to virt-yajl.m4 instead of
configure.ac as the other end of the linked check.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 619 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20130110/528cd981/attachment-0001.sig>
More information about the libvir-list
mailing list