[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 0/3] Fix various issues with libvirt networks



On 11.01.2013 12:09, Peter Krempa wrote:
> This patchset fixes various non-related issues with libvirt networking:
> 
> Peter Krempa (3):
>   network: bridge: Fix regression when defining persistent networks
>   virsh: Reformat output of virsh net-list
>   network: Report real error if addition of firewall rules fails
> 
>  src/network/bridge_driver.c | 10 ++++++++++
>  tools/virsh-network.c       |  7 ++++---
>  2 files changed, 14 insertions(+), 3 deletions(-)
> 

ACK to all three patches.

Although, reading the 2/3 made me realize maybe we need internal table
formatter or something. Doing it the current way isn't optimal.
Moreover, with fixed column width, we fail to format longer values than
the width. With table formatter we would still format table nice.

Michal


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]