[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 0/3] Fix various issues with libvirt networks



On 01/11/13 13:49, Michal Privoznik wrote:
On 11.01.2013 12:09, Peter Krempa wrote:
This patchset fixes various non-related issues with libvirt networking:

Peter Krempa (3):
   network: bridge: Fix regression when defining persistent networks
   virsh: Reformat output of virsh net-list
   network: Report real error if addition of firewall rules fails

  src/network/bridge_driver.c | 10 ++++++++++
  tools/virsh-network.c       |  7 ++++---
  2 files changed, 14 insertions(+), 3 deletions(-)


ACK to all three patches.

Thanks; I've pushed these.

Although, reading the 2/3 made me realize maybe we need internal table
formatter or something. Doing it the current way isn't optimal.
Moreover, with fixed column width, we fail to format longer values than
the width. With table formatter we would still format table nice.

I was considering this approach when I was trying to rework guest listing in virsh. The issue is even worse there.

Peter


Michal

--
libvir-list mailing list
libvir-list redhat com
https://www.redhat.com/mailman/listinfo/libvir-list



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]