[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] docs: add some more hacking tips



On 01/11/2013 01:31 AM, Peter Krempa wrote:

>> +        <p>There is also a <code>./run</code> script at the top level,
>> +          to make it easier to run uninstalled programs, as well as to
> 
> "uninstalled" sounds to me as if I'd just remove them from my system.
> I'd change that to "programs that have not been installed in the system"
> or something with similar explanation
> 
>> +          wrap invocations of various tests under gdb or valgrind.</p>
>>         </li>
>>         <li>Update tests and/or documentation, particularly if you are
>> adding
>>           a new feature or changing the output of a program.</li>
>>
> 
> ACK with the comment in the last hunk addressed

Done, and pushed.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]