[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 2/1] docs: mention git rename detection



On 01/11/2013 01:34 AM, Peter Krempa wrote:
> 
> It might also be beneficial to instruct the users to use the patience
> algorithm for diffs (especially when moving chunks of code around).

Indeed.

> 
> ACK as is.

I tweaked before pushing:

diff --git i/docs/hacking.html.in w/docs/hacking.html.in
index 1216f42..6485676 100644
--- i/docs/hacking.html.in
+++ w/docs/hacking.html.in
@@ -24,7 +24,9 @@
 <pre>
   git diff &gt; libvirt-myfeature.patch
 </pre>
-        <p>However, the usual workflow of libvirt developer is:</p>
+        <p>Also, for code motion patches, you may find that <code>git
+        diff --patience</code> provides an easier-to-read patch.
+        However, the usual workflow of libvirt developer is:</p>
 <pre>
   git checkout master
   git pull


-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]