[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] qemu: Fix grouping of capabilities strings



On 01/11/2013 11:47 AM, Peter Krempa wrote:
> Commit f8d478b6dfc46a0ad2459844b96937599dec06e1 broke the grouping by
> five items.
> ---
> Pushed under the trivial rule.
> ---
>  src/qemu/qemu_capabilities.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c
> index 25e8951..b166dd6 100644
> --- a/src/qemu/qemu_capabilities.c
> +++ b/src/qemu/qemu_capabilities.c
> @@ -200,7 +200,8 @@ VIR_ENUM_IMPL(qemuCaps, QEMU_CAPS_LAST,
>                "vmware-svga",
>                "device-video-primary",
>                "s390-sclp",
> -              "usb-serial",
> +
> +              "usb-serial", /* 125 */
>                "usb-net",


Wait. I thought we weren't going to use "usb-net" for this last device,
and that it instead should be named based on the type of hardware it was
emulating, and the fact that it was usb would be derived from the
guest-side address element. Did I miss a different message where
something else was decided?


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]