[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/2] docs: simplify code



At Fri, 11 Jan 2013 23:48:24 -0600,
Doug Goldstein wrote:
> 
> On Fri, Jan 11, 2013 at 4:55 PM, Eric Blake <eblake redhat com> wrote:
> > On 01/11/2013 04:20 AM, Claudio Bley wrote:
> >>
> >> Signed-off-by: Claudio Bley <cbley av-test de>
> >> ---
> >>  docs/apibuild.py |   10 ++--------
> >>  1 file changed, 2 insertions(+), 8 deletions(-)
> >>
> >
> > My python is very weak, so you may want a second opinion; but I at least
> > tested that this patch succeeded on RHEL 5.
> >
> > (weak) ACK.
> >
> > --
> > Eric Blake   eblake redhat com    +1-919-301-3266
> > Libvirt virtualization library http://libvirt.org
> 
> Only thing to note is the original code consumed 1 space, while this
> will consume all leading space.

Actually, it consumed 1 space, tab or * in a loop until the first
character wasn't a space, tab or *, respectively.

So, the new code is pretty much equivalent.

Claudio
-- 
AV-Test GmbH, Henricistra├če 20, 04155 Leipzig, Germany
Phone: +49 341 265 310 19
Web:<http://www.av-test.org>

Eingetragen am / Registered at: Amtsgericht Stendal (HRB 114076)
Geschaeftsfuehrer (CEO): Andreas Marx, Guido Habicht, Maik Morgenstern


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]