[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 08/28] Convert netcf check to use LIBVIRT_CHECK_PKG



On Fri, Jan 11, 2013 at 03:00:23PM -0700, Eric Blake wrote:
> On 01/11/2013 04:05 AM, Daniel P. Berrange wrote:
> > From: "Daniel P. Berrange" <berrange redhat com>
> > 
> > Signed-off-by: Daniel P. Berrange <berrange redhat com>
> > ---
> >  configure.ac     | 42 ++----------------------------------------
> >  m4/virt-netcf.m4 | 40 ++++++++++++++++++++++++++++++++++++++++
> >  2 files changed, 42 insertions(+), 40 deletions(-)
> >  create mode 100644 m4/virt-netcf.m4
> > 
> 
> > +
> > +AC_DEFUN([LIBVIRT_CHECK_NETCF],[
> > +  LIBVIRT_CHECK_PKG([NETCF], [netcf], [0.1.4])
> > +
> > +  if test "$with_netcf" = "yes" ; then
> > +    old_CFLAGS="$CFLAGS"
> > +    old_LIBS="$CFLAGS"
> > +    CFLAGS="$CFLAGS $NETCF_CFLAGS"
> > +    LIBS="$LIBS $NETCF_LIBS"
> > +    AC_CHECK_FUNC([ncf_change_begin], [netcf_transactions=1], [netcf_transactions=0])
> > +    if test "$netcf_transactions" = "1" ; then
> > +        AC_DEFINE_UNQUOTED([HAVE_NETCF_TRANSACTIONS], 1,
> 
> Autoconf recommends writing that second parameter as [1], not unadorned
> 1, for consistency; but it doesn't matter in practice.

Changed it anyway

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]