[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 12/28] Convert avahi check to use LIBVIRT_CHECK_PKG



On Fri, Jan 11, 2013 at 03:11:54PM -0700, Eric Blake wrote:
> On 01/11/2013 04:05 AM, Daniel P. Berrange wrote:
> > From: "Daniel P. Berrange" <berrange redhat com>
> > 
> > Signed-off-by: Daniel P. Berrange <berrange redhat com>
> > ---
> >  configure.ac     | 34 ++--------------------------------
> >  m4/virt-avahi.m4 | 26 ++++++++++++++++++++++++++
> >  2 files changed, 28 insertions(+), 32 deletions(-)
> >  create mode 100644 m4/virt-avahi.m4
> > 
> 
> > -  AC_HELP_STRING([--with-avahi], [use avahi to advertise remote daemon @<:@default=check@:>@]),
> 
> > +
> > +AC_DEFUN([LIBVIRT_CHECK_AVAHI],[
> > +  LIBVIRT_CHECK_PKG([AVAHI], [avahi-client], [0.6.0])
> 
> Hmm.  I just noticed that the new './configure --help' message is more
> generic for every library we've been replacing, such as:
> 
>   --with-avahi            with libavahi-client support [default=check]
> 
> Should we enhance LIBVIRT_CHECK_PKG to add an optional fourth parameter,
> which is additional hint text to add to the AS_HELP_STRING message about
> WHY using the library might be worthwhile?  That is, I'm thinking
> something like:
> 
>   LIBVIRT_CHECK_PKG([AVAHI], [avahi-client], [0.6.0],
>     [used for advertising remote daemon])
> 
> and generating:
> 
>   --with-avahi            with libavahi-client support [default=check],
>                           used for advertising remote daemon
> 
> But that's an independent question, and affects ALL of the converted
> libraries, so it does not prevent me from giving:

I guess the problem I'm seeing is that these libraries can be used for
many different things, and the macros here don't really know what.
It is the hypervisor drivers which know what feature is done by each
library.

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]