[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 9/9] cleanup libvirt_private.syms



On 01/14/2013 12:42 PM, Michal Privoznik wrote:
> On 14.01.2013 15:34, Osier Yang wrote:
>> This fixes the header names (all util files are named with "vir"
>> prefix now. Some of them are not util files, but the name has been
>> changed), and sort the whole libvirt_private.syms by the header name
>> after the name fixes.
>> ---
>>  src/libvirt_private.syms | 1164 +++++++++++++++++++++++-----------------------
>>  1 files changed, 583 insertions(+), 581 deletions(-)
> 
> Wow. slightly bigger change, but splitting it into slices doesn't make
> any sense. I did compile check and it passed. So you have my ACK, but I
> would give others some time to make deeper review if they want to.

Looked good in my quick read through as well.  No complaints if you push
it, since 'make check' validates that we aren't exposing too many or
missing any names.  ACK.


-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]