[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[libvirt] [PATCH v2 0/4] Resolved CHECKED_RETURN errors found by Coverity



Rather then further muddy the waters of the previous patch series, this is
a fresh patch series. I added one patch to this since the code was in the
same general area as the virBufferTrim patch.

Differences in v2

rpc:
Updated the commit message to include why only putting out a VIR_WARN.
The code did not change.

The original patch:
https://www.redhat.com/archives/libvir-list/2013-January/msg00103.html

tools:
Rework the patch to check the virBufferTrim() status return. Added
virBufferError() status check after virBufferAddLit() to match the
similar check after virBufferAddChar().

The original patch:
https://www.redhat.com/archives/libvir-list/2013-January/msg00118.html

xen:
Resend of the v2 patch to keep in the same series:

https://www.redhat.com/archives/libvir-list/2013-January/msg00473.html

which was the replacement for:

https://www.redhat.com/archives/libvir-list/2013-January/msg00114.html

util:
(new) The coverity error was NEGATIVE_RETURNS. The complaint being
the potential to call memset() with a negative indent value. Since
virBufferGetIndent() will check and fail on buf->error, I removed that
check from virBufferAdd() and used the -1 return as the way to exit.

John Ferlan (4):
  rpc: Check and message setsockopt()
  tools: Check return status on virBufferTrim()
  xen: Ignore return status for TCP_NODELAY
  util: Check for negative indent in virBufferAdd

 src/rpc/virnetsocket.c  |  4 +++-
 src/util/virbuffer.c    |  5 ++---
 src/xen/xend_internal.c |  7 +++----
 tools/virsh.c           | 11 ++++++++---
 4 files changed, 16 insertions(+), 11 deletions(-)

-- 
1.7.11.7


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]