[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [RFC PATCH v1 5/7] cgroup: refactor virCgroup



On Wed, Jan 16, 2013 at 10:53:07AM +0800, Hu Tao wrote:
> This patch adds a new structure, virCgroupItem, to represent
> a cgroup directory(named cgroup item). cgroup directory is
> created when needed and removed if no one is using it.
> ---
>  src/libvirt_private.syms |   7 +
>  src/util/vircgroup.c     | 411 ++++++++++++++++++++++++++++++++++++++++++++++-
>  src/util/vircgroup.h     |  12 ++
>  3 files changed, 423 insertions(+), 7 deletions(-)

NACK to this whole change. See my comments in patch 6/7 for why
this API change to cgroups is a really bad design idea.


Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]