[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [RFC PATCH v1 0/7] virCgroup refactor



On Wed, Jan 16, 2013 at 10:53:02AM +0800, Hu Tao wrote:
> Hi,
> 
> This series is posted for early review.
> 
> This series refactors virCgroup. The changes are:
> 
>   - virCgroupItem is associated with a cgroup directory. The directory
>     is created only when needed, and removed if no one is using it.
>   - Anyone using cgroups creates instances of virCgroupItem and maintains
>     their lifetime.
> 
> Please focus on patch #5, which brings the main change(virCgroupItem),
> and qemu part in patch #6, which shows the usage of virCgroupItem(I've not
> tested lxc part yet).

I'm really not to clear on what the actual functional benefit or
changes of this series are, so it is hard to know how to suggest
changes to it. I do know that I don't like the design you have
here though, no matter what the goal.

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]