[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 00/12] Introduce public APIs for dealing with virTypedParameters



On Thu, Jan 17, 2013 at 16:24:43 +0800, Daniel Veillard wrote:
> On Wed, Jan 16, 2013 at 03:20:05PM +0100, Jiri Denemark wrote:
> > Working with virTypedParameters in clients written in C is ugly and
> > requires all clients to duplicate the same code. This set of APIs makes
> > this code for manipulating with virTypedParameters integral part of
> > libvirt so that all clients may benefit from it.
> > 
> > Jiri Denemark (12):
> >   Add virTypedParams* APIs
> >   virsh: Use virTypedParams* APIs in blkdeviotune
> >   virsh: Use virTypedParams* APIs in blkiotune
> >   virsh: Use virTypedParams* APIs in domiftune
> >   virsh: Use virTypedParams* APIs in schedinfo
> >   virsh: Use virTypedParams* APIs in domblkstat
> >   virsh: Use virTypedParams* APIs in memtune
> >   virsh: Use virTypedParams* APIs in numatune
> >   virsh: Use virTypedParams* APIs in node-memory-tune
> >   virsh: Use virTypedParams* APIs in cpu-stats
> >   Introduce virTypedParamsClear public API
> 
>   In general agreement, the virTypedParams are the most complex
> construct of our APIs (beside the XML data) and this goes a long
> way to make them easier to use. We should probably add a small example
> somewhere in the documentation too (but where ?)

Ideally, this would go into the developer guide if it wasn't incomplete
and several years old. I think virsh could serve as a documentation
until the guide is in a better shape :-)

> >   python: Avoid freeing uninitialized new_params pointer
> 
>   This one can go in asynch, it's a bug fix, ACK on that one

Thanks, I pushed it.

Jirka


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]