[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] conf: don't fail to parse <boot> element when parsing a single device



On 01/17/2013 09:29 AM, Laine Stump wrote:
> This resolves:
> 
>   https://bugzilla.redhat.com/show_bug.cgi?id=895294
> 
> The symptom was that attempts to modify a network device using
> virDomainUpdateDeviceFlags() would fail if the original device had a
> <boot> element (e.g. "<boot order='1'/>"), even if the updated device
> had the same <boot> element. Instead, the following error would be logged:
> 
>   cannot modify network device boot index setting
> 
> It's true that it's not possible to change boot order (internally
> known as bootIndex) of a live device; qemuDomainChangeNet checks for
> that, but the problem was that the information it was checking was
> incorrect.
> 
> Explanation:

<snipped>

Interesting how it takes a huge explanation to justify a one-line commit :)

ACK.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]