[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] qemu: Double mutex unlock in qemuDomainModifyDeviceFlags



On 01/17/2013 11:46 AM, Jiri Denemark wrote:
> On Thu, Jan 17, 2013 at 18:25:28 +0100, Viktor Mihajlovski wrote:
>> The driver mutex was unlocked in qemuDomainModifyDeviceFlags before
>> entering qemuDomainObjBeginJobWithDriver where it will be unlocked once
>> more leaving it in an undefined state. The result was that two
>> threads were simultaneously looking up the domain hash table during
>> multiple parallel device attach/detach operations.
>> Luckily this triggered a virHashIterationError.
>>
>> Signed-off-by: Viktor Mihajlovski <mihajlov linux vnet ibm com>
>> ---

> 
> ACK. The function relies on driver being locked and unlocks it in
> cleanup phase.

Pushed.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]