[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[libvirt] [PATCH 00/10] Patches for various coverity issues



locking:
Fixes Coverity OVERRUN warning due to the size of the source string being
19 bytes and the memcpy size of 48 bytes

security:
Fixes Coverity warning STRING_OVERFLOW about due to the copy being from a
variable sized string to a fixed length string.  Even though on read other
checks ensure the source buffer is no longer than the number of bytes in
the destination, Coverity doesn't know that.

rpc:
Fixes Coverity warning DEADCODE due to removal of code as specified in
the commit message

parallels:
Fixes Coverity warning NULL_RETURNS from not checking result of
virJSONValueObjectGetString() call as part of commit id: 8ce9e2ab

util:
Fixes Coverity warning NULL_RETURNS due to not checking the return
value 'child' from a virJSONValueNewObject() call.

qemu:
Fixes Coverity warning NULL_RETURNS from not checking the return
value 'activeDev' from a pciDeviceListFind() call.

selinux:
Fixes Coverity warning RESOURCE_LEAK as a result of code specified in
the commit message

esx:
Fixes Coverity warning REVERSE_INULL as a result of needlessly checking
if objectSpec != NULL.  At the point in the code, objectSpec must be valid.

virobject:
Fixes Coverity warning CONSTANT_EXPRESSION_RESULT and DEADCODE as a
result of commit id b545f65 using "if (!virObjectInitialize() < 0)"

network:
Fixes Coverity warning UNUSED_VALUE as specific in the commit message

John Ferlan (10):
  locking: use virStrcpy instead of memcpy
  security: Use virStrcpy to move the label
  rpc: Remove call to virKeepAliveStop at init
  parallels: Need to handle virJSONValueObjectGetString error
  util: Need to check child JSON allocation before use
  qemu: Check valid activeDev before calling pciDeviceSetUsedBy
  selinux: Resolve resource leak using the default disk label
  esx: No need to check for objectSpec
  virobject: Remove the bogus ! from call to virObjectInitialize()
  network: Remove dead code getting, but not using ipdef

 src/conf/domain_conf.c            | 29 +++++++++++++++++++++++++++++
 src/conf/domain_conf.h            |  3 +++
 src/esx/esx_vi.c                  |  7 +++----
 src/locking/lock_driver_sanlock.c |  9 ++++++++-
 src/network/bridge_driver.c       |  3 ---
 src/parallels/parallels_driver.c  |  5 ++++-
 src/qemu/qemu_hostdev.c           |  3 ++-
 src/rpc/virnetserverclient.c      |  2 --
 src/security/security_dac.c       |  8 +++++++-
 src/security/security_selinux.c   |  6 +++---
 src/util/virlockspace.c           |  3 +++
 src/util/virobject.c              |  4 ++--
 12 files changed, 64 insertions(+), 18 deletions(-)

-- 
1.7.11.7


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]