[libvirt] [PATCH 03/10] rpc: Remove call to virKeepAliveStop at init
Peter Krempa
pkrempa at redhat.com
Thu Jan 17 19:57:15 UTC 2013
On 01/17/13 20:17, John Ferlan wrote:
> This code is not reachable as of commit id: bb85f229.
> ---
> src/rpc/virnetserverclient.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/src/rpc/virnetserverclient.c b/src/rpc/virnetserverclient.c
> index 85239dd..e254309 100644
> --- a/src/rpc/virnetserverclient.c
> +++ b/src/rpc/virnetserverclient.c
> @@ -1360,8 +1360,6 @@ virNetServerClientInitKeepAlive(virNetServerClientPtr client,
>
> cleanup:
> virObjectUnlock(client);
> - if (ka)
> - virKeepAliveStop(ka);
> virObjectUnref(ka);
This unref also doesn't make sense. The cleanup path is reached only
when ka is NULL. This allows to optimize the function even more.
>
> return ret;
>
More information about the libvir-list
mailing list