[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 00/12] Introduce public APIs for dealing with virTypedParameters



On 16.01.2013 15:20, Jiri Denemark wrote:
> Working with virTypedParameters in clients written in C is ugly and
> requires all clients to duplicate the same code. This set of APIs makes
> this code for manipulating with virTypedParameters integral part of
> libvirt so that all clients may benefit from it.
> 
> Jiri Denemark (12):
>   Add virTypedParams* APIs
>   virsh: Use virTypedParams* APIs in blkdeviotune
>   virsh: Use virTypedParams* APIs in blkiotune
>   virsh: Use virTypedParams* APIs in domiftune
>   virsh: Use virTypedParams* APIs in schedinfo
>   virsh: Use virTypedParams* APIs in domblkstat
>   virsh: Use virTypedParams* APIs in memtune
>   virsh: Use virTypedParams* APIs in numatune
>   virsh: Use virTypedParams* APIs in node-memory-tune
>   virsh: Use virTypedParams* APIs in cpu-stats
>   Introduce virTypedParamsClear public API
>   python: Avoid freeing uninitialized new_params pointer
> 
>  daemon/remote.c              |  34 +-
>  include/libvirt/libvirt.h.in |  95 ++++++
>  python/generator.py          |  20 ++
>  python/libvirt-override.c    |  73 ++--
>  src/libvirt_private.syms     |   1 -
>  src/libvirt_public.syms      |  18 +
>  src/remote/remote_driver.c   |   4 +-
>  src/rpc/gendispatch.pl       |   3 +-
>  src/util/virtypedparam.c     | 782 ++++++++++++++++++++++++++++++++++++++++++-
>  src/util/virtypedparam.h     |   2 -
>  tools/virsh-domain-monitor.c |   5 +-
>  tools/virsh-domain.c         | 542 +++++++++++-------------------
>  tools/virsh-host.c           |  78 ++---
>  tools/virsh.c                |  20 --
>  14 files changed, 1171 insertions(+), 506 deletions(-)
> 

ACK series.

Michal


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]