[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Have a colorful nodedev.rng with vi



On 01/18/2013 02:19 AM, Osier Yang wrote:
> Just add the head line to let vi known it's a XML document.

s/known/know/

> ---
>  docs/schemas/nodedev.rng |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)

ACK to the idea, but before you push...

> 
> diff --git a/docs/schemas/nodedev.rng b/docs/schemas/nodedev.rng
> index 7c85815..04d8ee9 100644
> --- a/docs/schemas/nodedev.rng
> +++ b/docs/schemas/nodedev.rng
> @@ -1,3 +1,4 @@
> +<?xml version="1.0"?>

Please extend this to cover ALL of the .rng files; right now, my quick
grep showed two other culprits that need the same fix (vs. 11 that were
correct):

$ grep -l -L '?xml version=.1' docs/schemas/*.rng
docs/schemas/capability.rng
docs/schemas/nodedev.rng
docs/schemas/storageencryption.rng

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]