[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCHv2] spec: indent %if to make it easier to see conditions



On Fri, Jan 18, 2013 at 09:58:22AM -0700, Eric Blake wrote:
> Nested conditionals are hard to read if they are not indented.
> We can't add arbitrary whitespace to everything in spec files,
> but we CAN add spaces before %if and %define.  Use this trick,
> plus a fancy sed script that rewrites a spec file into a C
> file, so we can use cppi to keep our spec file nice.


What would you say to making the indent level either 2 or 4
space. With only one space, I still find it rather hard to
visually match up vertical alignment in our header files.
4 space indent would match our source code indent, but if
you didn't want to go that far, 2 would be acceptable
compromise.

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]