[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[libvirt] [PATCH 00/17] virsh: Rework string option retrieval



This patchset fixes retrieval of string arguments in virsh to report sane
errors in all the places it's used. A new string option retrieval function is
added that supports error reporting and changes appropriate places to use it.

Along with that this series cleans up a few places with old code and bad style.

*** BLURB HERE ***

Peter Krempa (17):
  virsh-snapshot: Fix coding style and remove dead code
  virsh-volume: Rename helper function makeCloneXML to vshMakeCloneXML
  virsh-pool: Rename helper function buildPoolXML to vshBuildPoolXML
  virsh: Add helper to request string arguments with error reporting
  virsh-pool: Update pool commands to use vshCommandOptStringReq
  virsh-volume: Update volume commands to use vshCommandOptStringReq
  virsh-domain-monitor: Update domain commands to use
    vshCommandOptStringReq
  virsh-domain: Update domain commands to use vshCommandOptStringReq
  virsh-host: Update host commands to use vshCommandOptStringReq
  virsh-network: Update network commands to use vshCommandOptStringReq
  virsh-interface: Update interface commands to use
    vshCommandOptStringReq
  virsh-nodedev: Update node device commands to use
    vshCommandOptStringReq
  virsh-nodedev: Refactor error paths, error messages and whitespace
  virsh-snapshot: Refactor cmdSnapshotDumpXML
  virsh-snapshot: Update snapshot commands to use vshCommandOptStringReq
  virsh-nwfilter: Update nwfilter commands to use vshCommandOptStringReq
  virsh-secret: Refactor error paths

 tools/virsh-domain-monitor.c |  44 +++----
 tools/virsh-domain.c         | 299 +++++++++++++++++--------------------------
 tools/virsh-host.c           |   9 +-
 tools/virsh-interface.c      |   8 +-
 tools/virsh-network.c        |  19 +--
 tools/virsh-nodedev.c        |  44 ++++---
 tools/virsh-nwfilter.c       |   4 +-
 tools/virsh-pool.c           |  56 ++++----
 tools/virsh-secret.c         |  30 +++--
 tools/virsh-snapshot.c       |  55 +++-----
 tools/virsh-volume.c         |  73 +++++------
 tools/virsh.c                |  51 ++++++++
 tools/virsh.h                |   4 +
 13 files changed, 320 insertions(+), 376 deletions(-)

-- 
1.8.1.1


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]