[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [libvirt-glib 1/2] Use g_strlcpy instead of strncpy



On Wed, Dec 19, 2012 at 01:59:42PM +0100, Christophe Fergeau wrote:
> Ping?

Time for another ping ;)

> On Fri, Dec 14, 2012 at 05:03:37PM +0100, Christophe Fergeau wrote:
> > This guarantees that the string will be nul-terminated. Coverity
> > warned about this issue.
> > ---
> >  libvirt-gobject/libvirt-gobject-connection.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/libvirt-gobject/libvirt-gobject-connection.c b/libvirt-gobject/libvirt-gobject-connection.c
> > index 91cc535..0525323 100644
> > --- a/libvirt-gobject/libvirt-gobject-connection.c
> > +++ b/libvirt-gobject/libvirt-gobject-connection.c
> > @@ -1583,7 +1583,7 @@ GVirNodeInfo *gvir_connection_get_node_info(GVirConnection *conn,
> >      }
> >  
> >      ret = g_slice_new(GVirNodeInfo);
> > -    strncpy (ret->model, info.model, sizeof (ret->model));
> > +    g_strlcpy (ret->model, info.model, sizeof (ret->model));
> >      ret->memory = info.memory;
> >      ret->cpus = info.cpus;
> >      ret->mhz = info.mhz;
> > -- 
> > 1.8.0.2
> > 
> > --
> > libvir-list mailing list
> > libvir-list redhat com
> > https://www.redhat.com/mailman/listinfo/libvir-list



> --
> libvir-list mailing list
> libvir-list redhat com
> https://www.redhat.com/mailman/listinfo/libvir-list

Attachment: pgpOYVyfZ4MKk.pgp
Description: PGP signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]