[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[libvirt] [PATCH 0/6] More Coverity changes



Like a gift that keeps on giving... More Coverity changes.

Adjust changes from earlier based on Eric's comments/feedback.

nodeinfo.c - use sa_assert() instead of comment:
https://www.redhat.com/archives/libvir-list/2013-January/msg01578.html

virnetclient.c - remove change - the VIR_FREE change resolves this:
https://www.redhat.com/archives/libvir-list/2013-January/msg01581.html

Two new Coverity warnings popped up today (lxc_driver.c & lxc_process.c).
No rhyme or reason, they just were new with no recent change to blame
(very strange).

I missed the virnettlscontexttest.c and it's VIR_FREE() warning this
morning because it's before all the BAD_SIZEOF.  The virbitmaptest.c
change was on another branch waiting - I just moved it here.

One more major change and some fixups still due on prior changes and 
the number of Coverity warnings goes below 50 of which 35 are related 
to the sdt macros (started at 297).

John Ferlan (6):
  nodeinfo: Use sa_assert() instead of Coverity error tag
  tests: Remove VIR_FREE() on static/stack buffer (der.data)
  lxc_driver: Need to check for vm before calling virDomainUnlock(vm)
  lxc_process: Avoid passing NULL iface->iname
  rpc: Revert Coverity tag message
  virbitmaptest: Resolve Coverity errors

 src/lxc/lxc_driver.c         |  3 ++-
 src/lxc/lxc_process.c        | 14 ++++++++------
 src/nodeinfo.c               |  4 ++--
 src/rpc/virnetclient.c       |  1 -
 tests/virbitmaptest.c        | 24 ++++++++++++++++--------
 tests/virnettlscontexttest.c |  3 ---
 6 files changed, 28 insertions(+), 21 deletions(-)

-- 
1.7.11.7


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]