[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] auto-create pci-bridge controller info



On Wed, Jan 23, 2013 at 06:05:42AM -0700, Eric Blake wrote:
> On 01/23/2013 03:05 AM, Daniel P. Berrange wrote:
> > On Wed, Jan 23, 2013 at 09:45:20AM +0800, liguang wrote:
> >> if some devices specify a pci bus number that
> >> haven't been defined by a pci-bridge controller
> >> then fill the required correct controller info
> >> silently.
> >> it based on previous add pci-bridge support patches,
> >> https://www.redhat.com/archives/libvir-list/2013-January/msg00577.html
> >>
> >> Signed-off-by: liguang <lig fnst cn fujitsu com>
> >> ---
> >>  src/conf/domain_conf.c |   95 ++++++++++++++++++++++++++++++++++++++++++++++++
> >>  1 files changed, 95 insertions(+), 0 deletions(-)
> > 
> > ACK
> 
> However, it fails to compile:
> 
>   CC       libvirt_conf_la-domain_conf.lo
> conf/domain_conf.c: In function 'virDomainDefMaybeAddPcibridgeController':
> conf/domain_conf.c:11829:44: error:
> 'VIR_DOMAIN_CONTROLLER_TYPE_PCIBRIDGE' undeclared (first use in this
> function)
> 
> Please resubmit a fixed version.

I believe it depends on the earlier PCI patches which have not yet been
agreed on.


Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]