[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 3/6] Introduce new XMLs to specify disk source using storage pool/vol



On Wed, Jan 23, 2013 at 07:04:35PM +0800, Osier Yang wrote:
> With this patch, one can specify the disk source using storage
> pool/volume like:
> 
>   <disk type='file' device='disk'>
>     <driver name='qemu' type='raw' cache='none'/>
>     <source type='pool'>
>       <volume key='/var/lib/libvirt/images/foo.img'/>
>       <seclabel relabel='no'/>
>     </source>
>     <target dev='vdb' bus='virtio'/>
>   </disk>
> 
>   <disk type='file' device='disk'>
>     <driver name='qemu' type='raw' cache='none'/>
>     <source type='pool'>
>       <volume path='/var/lib/libvirt/images/foo.img'/>
>       <seclabel relabel='no'/>
>     </source>
>     <target dev='vdb' bus='virtio'/>
>   </disk>
> 
>   <disk type='file' device='disk'>
>     <driver name='qemu' type='raw' cache='none'/>
>     <source type='pool'>
>       <pool uuid|name="$var"/>
>       <volume name='foo.img'/>
>       <seclabel relabel='no'/>
>     </source>
>     <target dev='vdb' bus='virtio'/>
>   </disk>


If you're going to introduce new  schema for <source>,
then you must introduce a new disk type value.ie a
<disk type='file'> must always use the <source file='...'/>
XML syntax, otherwise you cause backwards compatibility
problems for applications

What you need here is a <disk type='volume'/> for your
new schema.


Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]