[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] qemu: Move one misplaced driver unlock to the right function

On 01/23/2013 06:24 AM, Viktor Mihajlovski wrote:
> On 01/18/2013 06:21 PM, Eric Blake wrote:
>>> Yuck.  You _still_ haven't fixed DomainHasManagedSaveImage (which
>>> 8c5d2ba claimed to fix), and we've found yet another bogus commit.  We
>>> need a v2 of this patch that scrubs ALL of the bugs at once.
> Stepping thru the history of qemu_driver.c I saw that commit 2745177b
> has removed the driver lock. If 8c5d2ba was trying to do the same
> this has probably caused a rebase conflict, which seems to have
> been not resolved correctly, resulting in the broken
> commit. So there's nothing to do for DomainHasManagedSaveImage.

Aha, that explains it.  Thanks for doing the legwork on this.

> Look out for the V2 version...

Yep, and I'll push it shortly.

Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]