[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[libvirt] [PATCH 0/2] Resolve Coverity issues in vbox_tmpl.c



This pair of patches resolves what amount to false positives in the
vbox_tmpl.c code relating to attempts to dereference NULL in the 2002
VBOX_API_VERSION call to 'vboxIIDFromUUID()'. It also removes "false
postives" from the various VBOX_UTF*_FREE() macros. Some code paths
checked if the arg was valid prior to calling free. That triggered 
Coverity into tagging other uses of the variables where the check wasn't
performed. While these changes resolve the Coverity issues there still
exists a "problem" where the VBOX_UTF<n>_TO_UTF<m> macros don't check the
return status from the called function nor does the code that uses the 
macros always check the returned arg2 for validity (125 occurrances).

John Ferlan (2):
  vbox: Address false positive for NULL dereference
  vbox: Adjust the UTF FREE macros

 src/vbox/vbox_tmpl.c | 77 ++++++++++++++++++++++++++--------------------------
 1 file changed, 38 insertions(+), 39 deletions(-)

-- 
1.7.11.7


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]