[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCHv2] qemu: Re-add driver unlock to qemuDomainSendKey



On 23.01.2013 14:55, Viktor Mihajlovski wrote:
> Should have been done in commit 56fd513 already, but was missed
> due to oversight: qemuDomainSendKey didn't release the driver lock
> in its cleanup section. This fixes an issue introduced by commit
> 8c5d2ba.
> 
> Signed-off-by: Viktor Mihajlovski <mihajlov linux vnet ibm com>
> ---
> V2 Changes:
>  - Removed bogus hunk for qemuDomainManagedSave
>  - Enhanced subject line and patch description
> 
>  src/qemu/qemu_driver.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
> index 72907d2..6d4c1e9 100644
> --- a/src/qemu/qemu_driver.c
> +++ b/src/qemu/qemu_driver.c
> @@ -2439,6 +2439,7 @@ endjob:
>  cleanup:
>      if (vm)
>          virObjectUnlock(vm);
> +    qemuDriverUnlock(driver);
>      return ret;
>  }
>  
> 

 Why do we need qemu driver locked throughout whole API? I don't think
we need so. If that's the case, we can simplify domain object lookup by
switching to qemuDomObjFromDomain. That is:

https://www.redhat.com/archives/libvir-list/2013-January/msg01760.html

Michal


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]