[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Fix performance & reliabilty of QMP probing



On Fri, Jan 25, 2013 at 04:14:18PM +0100, Viktor Mihajlovski wrote:
> On 01/24/2013 07:34 PM, Daniel P. Berrange wrote:
> >From: "Daniel P. Berrange" <berrange redhat com>
> >
> >This commit reverts the previous change, ensuring we do use the
> >-daemonize flag to QEMU. Startup delay is cut from 7 seconds
> >to 2 seconds on my machine, which is on a par with what it was
> >prior to the capabilities rewrite.
> >
> I have not that many QEMU instances, so I didn't see that degradation.
> >To deal with the fact that QEMU needs to be able to create the
> >pidfile, we switch pidfile location fron runDir to libDir, which
> >QEMU is guaranteed to be able to write to.
> >
> I tested your patch (with minor changes) and the QMP probing works
> without as expected with selinux, etc.
> Besides the debugging stuff that Eric and Laine mentioned
> you will also need to fix the CapsCacheNew signature hit in
> qemu_driver.c. I assume you have done that in your local tree
> but it's not in this patch.

Oh that change accidentally crept into the following patch and
has already been pushed

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]