[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v2 7/7] qemu: Destroy domain on decompression binary error



On 29.01.2013 09:59, Peter Krempa wrote:
> On 01/28/13 17:39, Michal Privoznik wrote:
>> https://bugzilla.redhat.com/show_bug.cgi?id=894723
>>
>> Currently, if qemuProcessStart() succeeds, but it's decompression
>> binary that returns nonzero status, we don't kill the qemu process,
>> but remove it from internal domain list, leaving the qemu process
>> hanging around totally uncontrolled.
>> ---
>>   src/qemu/qemu_driver.c | 4 +++-
>>   1 file changed, 3 insertions(+), 1 deletion(-)
> 
> My ACK on this one stands. It's a bug fix and this should go in before
> the release.
> 
> The rest of the series is quite complex and it will be better if you
> wait with it until the release is out. I will review your changes later
> today.
> 
> Peter
> 

Okay, I agree and I've pushed it (although it needed some rebase because
of context).

Michal


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]