[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH V1 1/4] Add support for QEMU -add-fd support detection



On 01/29/2013 06:24 PM, Eric Blake wrote:
On 01/29/2013 09:52 AM, Stefan Berger wrote:

Index: libvirt/src/qemu/qemu_capabilities.h
===================================================================
--- libvirt.orig/src/qemu/qemu_capabilities.h
+++ libvirt/src/qemu/qemu_capabilities.h
@@ -165,6 +165,7 @@ enum qemuCapsFlags {
      QEMU_CAPS_SCLP_S390          = 124, /* -device sclp* */
      QEMU_CAPS_DEVICE_USB_SERIAL  = 125, /* -device usb-serial */
      QEMU_CAPS_DEVICE_USB_NET     = 126, /* -device usb-net */
+    QEMU_CAPS_ADD_FD             = 127, /* -add-fd */
Okay, so you are taking the approach that we insist on command line
support (qemu 1.3), not just the QMP command existing (qemu 1.2).  It's
easy to probe whether 'add-fd' QMP exists (query-command), but harder to
determine if command line support is present when using just QMP with
the current state of qemu.

Would you then not use -add-fd on the command line but hotplug those devices instead?


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]