[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v2 7/7] docs: syntax highlight code blocks using SHJS



On 01/30/2013 04:39 AM, Claudio Bley wrote:
> At Tue, 29 Jan 2013 16:05:38 +0100,
> Claudio Bley wrote:
>>
>> Add minimized CSS and Javascript files of SHJS
>> (http://shjs.sourceforge.net/) required for highlighting C code.
> 
>>  docs/sh_c.min.js      |    1 +
>>  docs/sh_emacs.min.css |    1 +
>>  docs/sh_main.min.js   |    4 ++++
> 
> I did download those files directly from SourceForge without changing
> them. Since these files lack a final newline character "make check"
> fails on them.
> 
> Should we
> 
> a) add EOF to those files
> b) relax the rules for "make check"?

If we end up using the files, I'd vote for reformatting them to fit our
conventions.  We don't have to do verbatim copying of bad style.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]