[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 0/2] more work on qemu add-fd support



On Wed, Jan 30, 2013 at 09:21:44PM -0700, Eric Blake wrote:
> As promised, here's my first contribution into what is turning
> into a joint effort between myself and Stefan to support fd
> passing in qemu 1.3 and newer.  Patch 2 in this series is
> basically a rewrite of Stefan's patch 1/4, and I tested that
> the capability was successfully set on qemu 1.3 and clear on
> qemu 1.2.
> 
> I'm still wondering what we can do to the testsuite to expose
> more capability testing of qemu 1.2 and beyond (the existing
> qemuhelptest.c is hard-coded to -help scraping, which limits
> its usefulness; qemumonitorjsontest looks like a nice way to
> replay various QMP sessions, but we'd still need to figure out
> how to capture appropriate sessions from various qemu versions
> and replay them in the context of qemuhelptest).
> 
> Eric Blake (1):
>   qemu: expose qemu 1.3 add-fd monitor command
> 
> Stefan Berger (1):
>   Add support for QEMU -add-fd support detection
> 
>  src/qemu/qemu_capabilities.c | 22 ++++++++++++-
>  src/qemu/qemu_capabilities.h |  1 +
>  src/qemu/qemu_monitor.c      | 74 +++++++++++++++++++++++++++++++++++++++++++-
>  src/qemu/qemu_monitor.h      |  9 +++---
>  src/qemu/qemu_monitor_json.c | 73 ++++++++++++++++++++++++++++++++++++++++++-
>  src/qemu/qemu_monitor_json.h |  5 ++-
>  6 files changed, 176 insertions(+), 8 deletions(-)

ACK both, these are the uncontroversial parts


Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]