[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 02/11] xs: Code cleanup



On 2013年01月31日 02:51, John Ferlan wrote:
Housekeeping kind of stuff.
---
  src/xen/xs_internal.c | 108 +++++++++++++++++++++-----------------------------
  1 file changed, 45 insertions(+), 63 deletions(-)

diff --git a/src/xen/xs_internal.c b/src/xen/xs_internal.c
index 573c0c6..f823dfc 100644
--- a/src/xen/xs_internal.c
+++ b/src/xen/xs_internal.c
@@ -83,14 +83,10 @@ struct xenUnifiedDriver xenStoreDriver = {
   * Returns a string which must be freed by the caller or NULL in case of error
   */
  static char **
-virConnectDoStoreList(virConnectPtr conn, const char *path,
-                      unsigned int *nb)
+virConnectDoStoreList(virConnectPtr conn, const char *path, unsigned int *nb)
  {
      xenUnifiedPrivatePtr priv = (xenUnifiedPrivatePtr) conn->privateData;

-    if (priv->xshandle == NULL || path == NULL || nb == NULL)
-        return NULL;
-

virConnectDoStoreList is internal helper, and these arguments are
guaranteed not NULL. So ACK.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]