[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v3 04/13] libvirt.h.in: document virConnectDomainEventCallback's return value



On 01/30/2013 08:38 AM, Claudio Bley wrote:
> 
> Signed-off-by: Claudio Bley <cbley av-test de>
> ---
>  include/libvirt/libvirt.h.in |    2 ++
>  1 file changed, 2 insertions(+)

Hmm, I wonder if we should at least log any situation where the user's
callback returns non-zero, rather than flat-out ignoring it.

But I suppose this works well enough for the moment; ACK.

> 
> diff --git a/include/libvirt/libvirt.h.in b/include/libvirt/libvirt.h.in
> index 4222fe1..30762b1 100644
> --- a/include/libvirt/libvirt.h.in
> +++ b/include/libvirt/libvirt.h.in
> @@ -3441,6 +3441,8 @@ typedef enum {
>   * @opaque: opaque user data
>   *
>   * A callback function to be registered, and called when a domain event occurs
> + *
> + * Returns 0 (the return value is currently ignored)
>   */
>  typedef int (*virConnectDomainEventCallback)(virConnectPtr conn,
>                                               virDomainPtr dom,
> 

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]