[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Drop iptablesContext



On 06/28/2013 12:52 AM, Roman Bogorodskiy wrote:
> iptablesContext holds only 4 pairs of iptables
> (table, chain) and there's no need to pass
> it around.
>
> This is a first step towards separating bridge_driver.c
> in platform-specific parts.
> ---
>  src/libvirt_private.syms    |   2 -
>  src/network/bridge_driver.c | 253 +++++++++++++++++--------------------------
>  src/util/viriptables.c      | 257 +++++++++++---------------------------------
>  src/util/viriptables.h      |  65 ++++-------
>  4 files changed, 183 insertions(+), 394 deletions(-)

Now that 1.1.0 is released, I verified that this patch doesn't cause any
change in behavior, modified networkShutdownNetworkVirtual() to retain
the "driver" arg with an ATTRIBUTE_UNUSED (so that it's consistent with
other similar functions), and pushed the result.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]