[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Put virt-sanlock-cleanup into section 8



On 07/02/2013 03:36 PM, Guido Günther wrote:
> as indicates by the filename.

s/indicates/indicated/

> ---
>  tools/Makefile.am | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/Makefile.am b/tools/Makefile.am
> index 1dac7c1..644a86d 100644
> --- a/tools/Makefile.am
> +++ b/tools/Makefile.am
> @@ -99,7 +99,8 @@ virt-sanlock-cleanup: virt-sanlock-cleanup.in Makefile
>  	    || (rm $@ && exit 1) && chmod +x $@
>  
>  virt-sanlock-cleanup.8: virt-sanlock-cleanup.in $(top_srcdir)/configure.ac
> -	$(AM_V_GEN)$(POD2MAN) --name VIRT-SANLOCK-CLEANUP $< $(srcdir)/$@ \
> +	$(AM_V_GEN)$(POD2MAN) --name VIRT-SANLOCK-CLEANUP --section=8 \
> +	    $< $(srcdir)/$@ \

It would be nice if pod2man could auto-detect --section based on its
destination argument name (hmm, the man page says it already does just
that for .pm files, but not for .8).  But as we must operate with
existing software rather than waiting for a new pod2man, your patch
makes sense.  I didn't check if RHEL 5's pod2man supports the option,
but I guess I'll deal with any followup patches if I later run into
problems attempting 'make dist' from a RHEL 5 box.

Looks like daemon/Makefile.am needs the same tweak for libvirtd.8.

ACK if you fix that one too.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]