[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 3/8] Add qemuMonitorSetObjectProperty() method for QMP qom-set command



On Tue, Jul 02, 2013 at 09:39:21AM -0400, John Ferlan wrote:
> Add a new qemuMonitorSetObjectProperty() method to support invocation
> of the 'qom-set' JSON monitor command with a provided path, property, and
> expected data type to set.
> 
> The test code uses the same "/machine/i440fx" property as the get test and
> attempts to set the "realized" property to "true" (which it should be set
> at anyway).
> ---
>  src/qemu/qemu_monitor.c      | 23 ++++++++++++++++
>  src/qemu/qemu_monitor.h      |  5 ++++
>  src/qemu/qemu_monitor_json.c | 62 ++++++++++++++++++++++++++++++++++++++++++++
>  src/qemu/qemu_monitor_json.h |  6 +++++
>  tests/qemumonitorjsontest.c  | 59 +++++++++++++++++++++++++++++++++++++++++
>  5 files changed, 155 insertions(+)
> 

> diff --git a/src/qemu/qemu_monitor.h b/src/qemu/qemu_monitor.h
> index cc22123..b822b97 100644
> --- a/src/qemu/qemu_monitor.h
> +++ b/src/qemu/qemu_monitor.h
> @@ -727,6 +727,11 @@ int qemuMonitorGetObjectProperty(qemuMonitorPtr mon,
>                                   const char *property,
>                                   qemuMonitorObjectPropertyPtr prop);
>  
> +int qemuMonitorSetObjectProperty(qemuMonitorPtr mon,
> +                                 const char *path,
> +                                 const char *property,
> +                                 qemuMonitorObjectPropertyPtr prop);
> +

Again, I think we should not expose this method in qemu_monitor.h


Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]