[libvirt] [PATCH 1/2] qemu: Don't miss errors when changing graphics passwords
Daniel P. Berrange
berrange at redhat.com
Wed Jul 3 11:10:43 UTC 2013
On Tue, Jul 02, 2013 at 03:46:00PM +0200, Martin Kletzander wrote:
> Commit 23e8b5d8e7a92bac85b7fd2aca8992501bf680ee forgot to check the
> return value for all calls to qemuDomainChangeGraphicsPasswords().
>
> Signed-off-by: Martin Kletzander <mkletzan at redhat.com>
> ---
> src/qemu/qemu_process.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c
> index ac5ffcf..7dc7f65 100644
> --- a/src/qemu/qemu_process.c
> +++ b/src/qemu/qemu_process.c
> @@ -2015,10 +2015,10 @@ qemuProcessInitPasswords(virConnectPtr conn,
> &graphics->data.spice.auth,
> cfg->spicePassword);
> }
> - }
>
> - if (ret < 0)
> - goto cleanup;
> + if (ret < 0)
> + goto cleanup;
> + }
>
> if (virQEMUCapsGet(priv->qemuCaps, QEMU_CAPS_DEVICE)) {
> for (i = 0; i < vm->def->ndisks; i++) {
ACK
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
More information about the libvir-list
mailing list