[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH RESEND] LXC: fix memory leak when userns configuration is incorrect



On Wed, Jul 03, 2013 at 07:16:04PM +0800, Gao feng wrote:
> We forgot to free the stack when Kernel doesn't
> support user namespace.
> 
> Signed-off-by: Gao feng <gaofeng cn fujitsu com>
> ---
>  src/lxc/lxc_container.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/src/lxc/lxc_container.c b/src/lxc/lxc_container.c
> index 282c726..c8420db 100644
> --- a/src/lxc/lxc_container.c
> +++ b/src/lxc/lxc_container.c
> @@ -2131,6 +2131,7 @@ int lxcContainerStart(virDomainDefPtr def,
>          } else {
>              virReportSystemError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
>                                   _("Kernel doesn't support user namespace"));
> +            VIR_FREE(stack);
>              return -1;
>          }
>      }

ACK, will push shortly.

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]