[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v3 4/9] qemu_monitor: Introduce qemuMonitorAttachCharDev



On Tue, Jul 02, 2013 at 05:53:03PM +0200, Michal Privoznik wrote:
> The function being introduced is responsible for preparing and
> executing 'chardev-add' qemu monitor command. Moreover, in case
> of PTY chardev, the corresponding pty path is updated.
> ---
>  src/qemu/qemu_monitor.c      |  21 +++++
>  src/qemu/qemu_monitor.h      |   3 +
>  src/qemu/qemu_monitor_json.c | 182 +++++++++++++++++++++++++++++++++++++++++++
>  src/qemu/qemu_monitor_json.h |   3 +
>  4 files changed, 209 insertions(+)

Additions to the monitor APIs can be tested via the qemumonitorjsontest.c
test case. It'd be desirable to have coverage of all the chardev source
types involved here.

ACK, in case you prefer to add the test cases as a separate patch.


Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]