[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v2 12/14] libxl: pass ipaddr to libxl toolstack



On 06/12/2013 07:54 PM, Marek Marczykowski-Górecki wrote:
Do not silently ignore its value.

Signed-off-by: Marek Marczykowski-Górecki <marmarek invisiblethingslab com>
---
  src/libxl/libxl_conf.c | 2 ++
  1 file changed, 2 insertions(+)

diff --git a/src/libxl/libxl_conf.c b/src/libxl/libxl_conf.c
index d654ace..278c5e5 100644
--- a/src/libxl/libxl_conf.c
+++ b/src/libxl/libxl_conf.c
@@ -684,6 +684,8 @@ libxlMakeNic(libxlDriverPrivatePtr driver,
          case VIR_DOMAIN_NET_TYPE_ETHERNET:
              if (VIR_STRDUP(x_nic->script, l_nic->script) < 0)
                  return -1;
+            if (VIR_STRDUP(x_nic->ip, l_nic->data.bridge.ipaddr) < 0)

If the type is ETHERNET, shouldn't this be l_nic->data.ethernet.ipaddr ? Does this apply to type BRIDGE as well?

Regards,
Jim

+                return -1;
              break;
          default:
              virReportError(VIR_ERR_INTERNAL_ERROR,


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]