[libvirt] [PATCH] Split up platfrom specifics from bridge driver

Roman Bogorodskiy bogorodskiy at gmail.com
Thu Jul 4 16:25:31 UTC 2013


This is a second step for making bridge_driver more portable.

This one splits up bridge driver into platform specific and general
parts. Platform specifc parts are mostly firewalling stuff.

So the support for new platforms should be added by implementing
bridge_driver_$platform.c 

However, you might notice I didn't move some ports of the 
platform specific code. E.g. I left networkEnableIpForwarding
in bridge_driver.c because it feels like the implementation for 
e.g. all BSDs would be the same (while firewalling stuff would
be different on BSDs) to avoid code copy/paste.

Roman Bogorodskiy (1):
  Split up platfrom specifics from bridge driver

 po/POTFILES.in                       |    1 +
 src/Makefile.am                      |    5 +-
 src/network/bridge_driver.c          |  729 +---------------------------------
 src/network/bridge_driver_linux.c    |  709 +++++++++++++++++++++++++++++++++
 src/network/bridge_driver_noop.c     |   80 ++++
 src/network/bridge_driver_platform.c |   32 ++
 src/network/bridge_driver_platform.h |   77 ++++
 7 files changed, 915 insertions(+), 718 deletions(-)
 create mode 100644 src/network/bridge_driver_linux.c
 create mode 100644 src/network/bridge_driver_noop.c
 create mode 100644 src/network/bridge_driver_platform.c
 create mode 100644 src/network/bridge_driver_platform.h

-- 
1.7.9.5




More information about the libvir-list mailing list