[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 0/4] libxl: implement some chuncks of the NUMA interface



On lun, 2013-07-01 at 15:27 -0600, Eric Blake wrote:
> On 07/01/2013 03:20 PM, Jim Fehlig wrote:
> >> What I'm really not sure about is patch 03, which is something I need
> >> if I want
> >> patch 04 to function properly. Basically it is about advertising that
> >> the libxl
> >> driver supports VIR_TYPED_PARAM_STRING. I looked at how that is done
> >> in the
> >> qemu driver, but I'm not entirely sure I completely understood the
> >> logic behind
> >> it, so, please, tell me if I missed or misinterpreted anything!
> > 
> > I think we'll need another libvirt dev more familiar with this to
> > verify, but afaict advertising that the driver supports
> > VIR_TYPED_PARAM_STRING is required when returning a string in
> > virTypedParam, for compatibility with older libvirt clients. Without it,
> > strings wouldn't be returned to newer clients that support
> > VIR_TYPED_PARAM_STRING.
> 
> Any new API added after VIR_TYPED_PARAM_STRING was added can
> unconditionally assume that all callers are prepared to handle the
> string.  But for APIs that were created before string support was added,
> even if your driver doesn't implement the API until now, you are correct
> that you must advertise support for strings before returning any
> strings.  
>
Ok, I think I've understood this better now... I'll do as Jim suggest,
and add the proper bits to the functions, in the libxl driver, that need
them.

Thanks and Regards,
Dario

-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)

Attachment: signature.asc
Description: This is a digitally signed message part


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]