[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Don't spam logs with "port 0 must be in range" errors



On 04.07.2013 21:46, Jiri Denemark wrote:
> Whenever virPortAllocatorRelease is called with port == 0, it complains
> that the port is not in an allowed range, which is expectable as the
> port was never allocated. Let's make virPortAllocatorRelease ignore 0
> ports in a similar way free() ignores NULL pointers.
> ---
>  src/qemu/qemu_migration.c   |  4 ++--
>  src/qemu/qemu_process.c     | 27 +++++++++++----------------
>  src/util/virportallocator.c |  4 ++++
>  3 files changed, 17 insertions(+), 18 deletions(-)

Since making an application to listen on port 0 on Linux is almost
impossible I feel confident enough to give ACK.

Michal


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]