[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v1 20/37] Adapt to VIR_ALLOC and virAsprintf in src/qemu/*



On 07/04/2013 02:06 PM, Michal Privoznik wrote:
[...]
> diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
> index ba93233..7288ce7 100644
> --- a/src/qemu/qemu_command.c
> +++ b/src/qemu/qemu_command.c
> @@ -10289,7 +10186,7 @@ virDomainDefPtr qemuParseCommandLine(virCapsPtr qemuCaps,
>  
>              if (!(disk->src || disk->nhosts > 0) ||
>                  !disk->dst)
> -                goto no_memory;
> +                goto error;
>  

I can't see how this can get true in the code, especially due to no
memory.  However, this is there already, so I'm more curious than
concerned.  But please check that any possible OOMError gets reported in
this path.

ACK,

Martin


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]