[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v1 18/37] Adapt to VIR_ALLOC and virAsprintf in src/parallels/*



On 07/04/2013 02:06 PM, Michal Privoznik wrote:
> ---
>  src/parallels/parallels_driver.c  | 65 +++++++++++++++------------------------
>  src/parallels/parallels_network.c | 24 ++++-----------
>  src/parallels/parallels_storage.c | 50 +++++++++---------------------
>  src/parallels/parallels_utils.c   |  4 +--
>  4 files changed, 46 insertions(+), 97 deletions(-)
> 
> diff --git a/src/parallels/parallels_driver.c b/src/parallels/parallels_driver.c
> index d5e0ea3..dd4b13f 100644
> --- a/src/parallels/parallels_driver.c
> +++ b/src/parallels/parallels_driver.c
> @@ -118,35 +118,34 @@ parallelsBuildCapabilities(void)
>  
>      if ((caps = virCapabilitiesNew(virArchFromHost(),
>                                     0, 0)) == NULL)
> -        goto no_memory;
> +        return NULL;
>  
>      if (nodeCapsInitNUMA(caps) < 0)
> -        goto no_memory;
> +        goto error;
>  

Call to virBitmapSetBit() needs to be adapted in nodeCapsInitNUMAFake()
due to this hunk.

ACK with that fixed.

Martin


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]