[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v1 22/37] Adapt to VIR_ALLOC and virAsprintf in src/rpc/*



On 07/04/2013 02:06 PM, Michal Privoznik wrote:
> ---
>  src/rpc/gendispatch.pl        |  8 ++------
>  src/rpc/virnetclient.c        | 26 ++++++++------------------
>  src/rpc/virnetclientprogram.c | 12 +++---------
>  src/rpc/virnetclientstream.c  |  4 +---
>  src/rpc/virnetmessage.c       | 24 ++++++------------------
>  src/rpc/virnetserver.c        | 23 +++++++----------------
>  src/rpc/virnetserverclient.c  | 19 ++++---------------
>  src/rpc/virnetservermdns.c    | 20 +++++---------------
>  src/rpc/virnetserverprogram.c |  8 ++------
>  src/rpc/virnetserverservice.c | 12 +++---------
>  src/rpc/virnetsocket.c        |  8 ++------
>  src/rpc/virnetsshsession.c    | 21 +++++----------------
>  src/rpc/virnettlscontext.c    | 26 +++++++++++---------------
>  13 files changed, 59 insertions(+), 152 deletions(-)
> 

In src/rpc/virnetmessage.c:492:
void virNetMessageSaveError(virNetMessageErrorPtr rerr)

you should use VIR_ALLOC_QUIET to avoid overwriting the error message.

ACK

Jan


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]