[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] build: honor autogen.sh --no-git



On 07/08/2013 07:47 AM, Daniel P. Berrange wrote:
>>> Could you also expand
>>>
>>>   http://libvirt.org/compiling.html#building
>>>
>>> to describe how to build from GIT, but without needing direct
>>> net access. It has come up periodically & we don't have any
>>> docs about this aspect afaik.
>>>
>>> ACK to changes
>>
>> How does this work as a followup patch?  (Actually, I may just squash it
>> in with the gnulib patch and do it all at once...)

I'm still inclined to squash the two patches together.

>>
>> Hmm, this would be the first time the auto-generated HACKING file refers
>> to an in-tree html file (rather than an external project page), and I'm
>> not sure I like how the formatting turned out.  Any suggestions on how
>> to make that look better?

I figured it out; see
https://www.redhat.com/archives/libvir-list/2013-July/msg00446.html
which I plan to apply first, once it gets reviewed.

>>
>> diff --git i/HACKING w/HACKING
>> index a310faa..37e102c 100644
>> --- i/HACKING
>> +++ w/HACKING
>> @@ -36,7 +36,10 @@ developer is:
>>    git checkout -t origin -b workbranch
>>    Hack, committing any changes along the way
>>
>> -Then, when you want to post your patches:
>> +More hints on compiling can be found
>> +
>> +  here
>> +  compiling.html. When you want to post your patches:

With the xslt pre-req patch for <a> handling, this section of the
generated text-only HACKING file is now more legible as:

More hints on compiling can be found here <compiling.html>. When...

>> +++ w/docs/hacking.html.in
>> @@ -35,7 +35,9 @@
>>    git checkout -t origin -b workbranch
>>    Hack, committing any changes along the way
>>  </pre>
>> -        <p>Then, when you want to post your patches:</p>
>> +        <p>More hints on compiling can be
>> +        found <a href="compiling.html">here</a>.  When you want to
>> +        post your patches:</p>
>>  <pre>
>>    git pull --rebase
>>    (fix any conflicts)
> 
> ACK

Thanks for the review; I'll push soon.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]